nextcloud / nextcloud/workflow_pdf_converter

delete original: unable to rename, destination directory is not writable

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
26
Forks
8
Avg merge
10h 30m
Merged PRs (30d)
31

Description

When the source (original) should be deleted, an error message is logged: unable to rename, destination directory is not writable. In \OC\Files\Storage\Local::moveFromStorage() line 460 the user part of the URL is lost :-/

Apart from that, everything works fine, i.e. the file is deleted, only the PDF(s) remain.

Cf. https://github.com/nextcloud/pdf_converter/blob/master/lib/BackgroundJobs/Convert.php#L122-L126

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced Convert.php lines 122-126 and inspect OC\Files\Storage\Local::moveFromStorage() around line 460. Trace how the source URL is passed during deletion and verify that the user portion is preserved while the conversion still deletes the original and leaves the PDFs.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.