nextcloud / nextcloud/whiteboard
No user visible error when redis throws errors
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 215
- Forks
- 39
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 32
Description
I observed a case where redis had a maxmemory configured and reached it. In this case
The whiteboard server logs showed:
Failed to sweep cluster state: [ErrorReply: OOM command not allowed when used memory > "maxmemory'.]
Failed to write heartbeat: [ErrorReply: OOM command not allowed when used memory > 'maxmemory'.]
However for the end user it was not noticable that there was any problem, however two users could edit the file just not see their changes.
I think this case should be catched and the frontend should not allow editing the file if no proper connection could be made.
Websocket messages that happened:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing Redis reaching its maxmemory limit and tracing the whiteboard server logs and websocket messages described in the issue. Identify how the frontend detects a failed connection; done means users receive a visible error and cannot continue editing when changes cannot be persisted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, redis
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100