Make possible to specify the container element for the viewer
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 119
- Forks
- 72
- Avg merge
- 18h 42m
- Merged PRs (30d)
- 24
Description
The viewer does not set nor allows to set a specific element as the container of the modal dialog, and by default modal dialogs use the body element. However, in some cases the viewer needs to be appended to a different element (for example, if a sub-element is shown in fullscreen mode, like done in Talk), as otherwise it would not be visible.
How to test
- Open a conversation in Talk
- Share a picture in the conversation
- Switch to full screen mode
- Try to open the viewer for the picture
Expected result
The viewer is shown.
Actual result
The viewer is not shown (and neither its overlay).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/views/Viewer.vue, then read the referenced container handling in nextcloud-vue's src/components/Modal/Modal.vue. Reproduce the Talk fullscreen case by opening a shared picture in a fullscreen conversation. Done means the viewer and its overlay are visible when the viewer is opened from that context, while preserving the default behavior elsewhere.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100