Next and Previous not updating the URL correctly on first switch
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 119
- Forks
- 72
- Avg merge
- 18h 42m
- Merged PRs (30d)
- 24
Description
Describe the bug
When viewing images and clicking on Next or Previous, the URL in the browser is not updated to the actually shown image.
It is beeing updated only after Next or Previous is clicked a second time.
You can click Next, Previous, Next, Previous and so on without the URL beeing updated.
Click Next, then Next again and the URL is correctly updated.
Also click Previous, then Previous again to see the correct URL updated to the currently displayed image.
To Reproduce
Steps to reproduce the behavior:
- Go to 'files'
- Click on a folder with some images, open some image
- Notice the URL and hit Next once, then hit Previous
- Notice no change in URL altough another image is shown.
Expected behavior
Expected to see the correct URL to the actual shown image.
This happens only when clicking Next or Previous more than just once.
Screenshots
Not really applicable, but can be made on request.
Desktop
- OS: Windows / MacOS
- Browser: Chrome, Firefox, Safari
Smartphone
- OS: Android
- Browser stock browser
Browser log
No log output when switching Next or Previous.
Additional context
With Firefox(default installation) on Linux the URL is not refreshed at all, even after hitting Next or Previous multiple times.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the viewer by opening an image from a folder and switching with Next and Previous, including the Firefox case described. Trace how those controls change the displayed image and browser URL; done means the URL immediately matches the image shown after every switch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100