nextcloud / nextcloud/viewer

Web Browser Back Button in Image Preview unnoticeably acts on File Browser.

Open
#486 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
119
Forks
72
Avg merge
18h 42m
Merged PRs (30d)
24

Description

Detailed Description

When viewing a picture from nextcloud "Files" the backward and forward buttons of a web browser do apparently nothing, however in the background (behind the previewed picture) the file browser goes back or forward in its browsing history. (which is likely not intended and also not useful because you can't see it happening). The more likely user intents are:

  • go back to the previous picture viewed (however there are buttons for that)
  • close preview and show the file browser again (especially when only 1 picture was viewed before)

Steps to reproduce the behavior:

  1. Browser through some files using nextclound's "Files"
  2. Go to a folder containing one or several jpg or other pictures
  3. Click on one Picture
  4. Press Web Browser's Back button or back button on an android device
  5. "nothing" happens visibly, but the nextcloud file browser jumps back to where it came from.

Expected behavior

  • solution1: close the picture preview (same as clicking or tapping the cross symbol for closing the preview)

  • solution2: go back to the previously shown picture in preview (however this isn't really necessary as there are pretty visible arrows for forward and backward)

Desktop and Browsers Tested, NC Version

  • Linux/Firefox
  • Android/Chrome]
  • Nexctcloud Version 18.0.4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the issue by opening an image from Nextcloud Files and pressing the browser or Android back button, then inspect how the image preview handles browser history; done should make the back action visibly close the preview or otherwise follow the chosen expected behavior without changing the hidden file-browser history.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.