nextcloud / nextcloud/viewer

The slideshow starts unintentionally in photo editor

Open
#3,335 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug
Dominant language
JavaScript
Stars
119
Forks
72
Avg merge
18h 42m
Merged PRs (30d)
24

Description

Describe the bug
The slideshow mode starts while I am editing a photo.

To Reproduce
Steps to reproduce the behavior:

  1. Open a photo in the web application
  2. Click on 'Modify'
  3. Click on 'Draw' and 'Text'
  4. Draw a rectangle on the photo to add a text box
  5. Click inside the text box to edit the text
  6. Edit the text
  7. Press the 'enter' key on the keyboard
  8. The slideshow starts inside the photo editor

Expected behavior
Slideshow must NOT start !

Desktop (please complete the following information):

  • OS: Fedora 43
  • Browser LibreWolf 150.0.3-1
  • Nextcloud 32.0.9

Browser log

09:50:43,484 Uncaught TypeError: can't access property "contains", r.classList is undefined
    observer ImageEditor.vue:192
    observer ImageEditor.vue:191
    observer ImageEditor.vue:189
    mounted ImageEditor.vue:188
    VueJS 19
    toggleEditor Viewer.vue:597
    onEdit Viewer.vue:1190
    click NcActions-BcLis_nr.mjs:724
    VueJS 4
    click NcButton-BaZAY-tN.mjs:285
    VueJS 3
viewer-init.mjs:992:470
09:50:56,961 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313
09:51:01,838 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313
09:51:06,917 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313
09:51:11,902 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313
09:51:16,959 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313
09:51:17,315 Uncaught TypeError: can't access property "contains", r.classList is undefined
    observer ImageEditor.vue:192
    observer ImageEditor.vue:191
    observer ImageEditor.vue:189
    mounted ImageEditor.vue:188
    VueJS 19
    next Viewer.vue:1074
    VueJS 4
    next NcModal.mjs:484
    slideshowTimeout NcModal.mjs:572
    setTimeout handler*cB/this.start NcModal.mjs:90
    cB NcModal.mjs:112
    handleSlideshow NcModal.mjs:571
    slideshowTimeout NcModal.mjs:573
    setTimeout handler*cB/this.start NcModal.mjs:90
    cB NcModal.mjs:112
    handleSlideshow NcModal.mjs:571
    slideshowTimeout NcModal.mjs:573
    setTimeout handler*cB/this.start NcModal.mjs:90
    cB NcModal.mjs:112
    handleSlideshow NcModal.mjs:571
    slideshowTimeout NcModal.mjs:573
    setTimeout handler*cB/this.start NcModal.mjs:90
    cB NcModal.mjs:112
    handleSlideshow NcModal.mjs:571
    slideshowTimeout NcModal.mjs:573
viewer-init.mjs:992:470
09:51:22,170 [WARN] viewer: No files provided, skipping update 
Object { app: "viewer", uid: "Florent Pro", level: 2 }
previewUtils-C_mZ-BaB.chunk.mjs:14:313

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the web application by opening a photo, entering Modify > Draw > Text, and pressing Enter while editing text. Start with ImageEditor.vue around the observer at lines 188-192, then trace the related Viewer.vue and NcModal slideshow entries shown in the browser log. Done means pressing Enter no longer starts slideshow mode inside the photo editor and the reported TypeError is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.