Image viewer modal no longer closes when clicking out of image
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 119
- Forks
- 72
- Avg merge
- 18h 42m
- Merged PRs (30d)
- 24
Description
Describe the bug
When opening an image in the slideshow modal, clicking outside the image no longer closes the image. This is the same issue as in https://github.com/nextcloud/viewer/issues/646 that's snuck in.
To Reproduce
Open image, click outside the image but not where the arrows are. Previously the image would be closed, now it doesn't.
Expected behaviour
Image should be closed and returned to the previous page.
Screenshots
Clicking outside the image, but not on the image or arrows would close the image.
Desktop (please complete the following information):
- OS: Windows 11 Pro 22H2
- Browser: Chrome
- Version: 121.0.6167.185 (Official Build) (64-bit)
- Browser: Firefox
- Version: 122.0.1 (64-bit)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the image slideshow modal by opening an image and clicking outside it, away from the image and navigation arrows. Trace the modal's close behavior from the viewer entry point and verify that an outside click returns to the previous page without affecting clicks on the image or arrows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100