nextcloud / nextcloud/viewer

Editor: Text not saving when clicking outside

Open
#1,564 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug feature: editor
Dominant language
JavaScript
Stars
119
Forks
72
Avg merge
18h 42m
Merged PRs (30d)
24

Description

Describe the bug
When opening the image editor and choosing text input, the text is not save after clicking outside.

To Reproduce
Steps to reproduce the behavior:

  1. Open a image
  2. Open the editor
  3. choose text editing
  4. change the text
  5. click outside

Expected behavior
It should save the text when clicking outside

Actual behavior
It doesnt.

Screenshots
Text modification not applied in editor (2)

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chromium based
  • Version 110

Additional context
Tested with stable25 branch on 02.03.2023

This seems to be an upstream problem. See https://github.com/scaleflex/filerobot-image-editor/issues/239

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening an image, entering text editing, changing the text, and clicking outside. Then review the linked upstream Filerobot Image Editor issue to determine whether the fix belongs in this project; done means edited text remains applied after focus leaves the text input.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.