Follow-up after #1317
Open
Nobody has claimed this yet.
1. to develop
bug
enhancement
high
- Dominant language
- JavaScript
- Stars
- 119
- Forks
- 72
- Avg merge
- 18h 42m
- Merged PRs (30d)
- 24
Description
- Also are you sure that using a different name or file extension will always work? What about cases where you are only allowed to edit the file but not save in the target directory?
- Is the list of tools on the left accessible?
- Edit would be nicer directly in the top right, outside of 3-dot menu. (Needs change in component, but would also be generally nice to have more actions outside of that 3-dot menu like download and "Open sidebar")
- Use dark theme
- Disable when mobile
- on a publlic page does the auto-generated path look a bit strange and the dropdown is missing some spacing on the left?
- https://github.com/nextcloud/server/issues/33870
- https://github.com/nextcloud/server/issues/33869
cc @skjnldsv
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the viewer component and review the unchecked checklist items, especially the file-extension and target-directory questions, tool accessibility, and public-page layout. Compare the existing top-right actions, dark theme, mobile behavior, and public-page dropdown with the requested follow-up. Done means the remaining checklist items have clear resolutions and the affected viewer states behave as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100