Standardize full screen mode for viewer integrations
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 119
- Forks
- 72
- Avg merge
- 18h 42m
- Merged PRs (30d)
- 24
Description
Collabora and Text use a bit of a hacky approach to make the viewer show their content full screen with the special case that for Collabora the viewer header is actually hidden and the close/sidebar buttons are actually rendered by Collabora.
With https://github.com/nextcloud/viewer/pull/1229 that basically caused some regressions on the Text and Collabora side. To avoid that it would be good to have some indicator on the apps viewer integration that the modal content should span full width and height.
This could be handled similarly to https://github.com/nextcloud/viewer/pull/1051 to be an additional option on the handler registration.
Any objections @skjnldsv ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the viewer integration handler registration and compare the approach in pull requests #1051 and #1229. Define the full-width and full-height indicator as an additional registration option, then verify that Text and Collabora integrations avoid the reported regressions while preserving their viewer controls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100