nextcloud / nextcloud/user_saml

Multiple group memberships do not work

Open
#987 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug
Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce
  1. Install Nextcloud (here 31.0.7) and USER_SAML app (here: 7.0.0)
  2. Configure a SAML Identity Provider
  3. Use multiple group files
Expected behaviour

Multiple group memberships do not work anymore.

Actual behaviour

Each group field should result in a separate group membership, however existing group memberships will be overwritten/deleted. If only one group field is provided via SAML, the function works correctly.

Server configuration

Web server: Apache

Database: sqlite

PHP version: 31.0.7

Nextcloud version: (see Nextcloud admin page)

List of activated apps Enabled: - activity: 4.0.0 - app_api: 5.0.2 - bruteforcesettings: 4.0.0 - calendar: 5.5.3 - circles: 31.0.0 - cloud_federation_api: 1.14.0 - comments: 1.21.0 - contacts: 7.3.0 - contactsinteraction: 1.12.0 - dashboard: 7.11.0 - dav: 1.33.0 - federatedfilesharing: 1.21.0 - federation: 1.21.0 - files: 2.3.1 - files_downloadlimit: 4.0.0 - files_pdfviewer: 4.0.0 - files_reminders: 1.4.0 - files_sharing: 1.23.1 - files_trashbin: 1.21.0 - files_versions: 1.24.0 - firstrunwizard: 4.0.0 - logreader: 4.0.0 - lookup_server_connector: 1.19.0 - mail: 5.4.0 - nextcloud_announcements: 3.0.0 - notes: 4.12.3 - notifications: 4.0.0 - oauth2: 1.19.1 - password_policy: 3.0.0 - photos: 4.0.0 - privacy: 3.0.0 - profile: 1.0.0 - provisioning_api: 1.21.0 - recommendations: 4.0.0 - related_resources: 2.0.0 - richdocuments: 8.7.4 - richdocumentscode: 25.4.403 - serverinfo: 3.0.0 - settings: 1.14.0 - sharebymail: 1.21.0 - spreed: 21.1.4 - support: 3.0.0 - survey_client: 3.0.0 - systemtags: 1.21.1 - text: 5.0.0 - theming: 2.6.1 - twofactor_backupcodes: 1.20.0 - updatenotification: 1.21.0 - user_saml: 7.0.0 - user_status: 1.11.0 - viewer: 4.0.0 - weather_status: 1.11.0 - webhook_listeners: 1.2.0 - workflowengine: 2.13.0 Disabled: - admin_audit: 1.21.0 - encryption: 2.19.0 - files_external: 1.23.0 - suspicious_login: 9.0.1 - twofactor_nextcloud_notification: 5.0.0 - twofactor_totp: 13.0.0-dev.0 - user_ldap: 1.22.0
Nextcloud configuration

{
"system": {
"htaccess.RewriteBase": "/",
"memcache.local": "\OC\Memcache\APCu",
"apps_paths": [
{
"path": "/var/www/html/apps",
"url": "/apps",
"writable": false
},
{
"path": "/var/www/html/custom_apps",
"url": "/custom_apps",
"writable": true
}
],
"upgrade.disable-web": true,
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"nextcloud-test.wrobix.de"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "sqlite3",
"version": "31.0.7.1",
"overwrite.cli.url": "REMOVED SENSITIVE VALUE",
"overwriteprotocol": "https",
"installed": true
}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Nextcloud 31.0.7, USER_SAML 7.0.0, a SAML identity provider, and multiple group files. Trace the user_saml group-membership handling and verify that each supplied group is retained without overwriting existing memberships.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, php, sqlite
Domain
authentication, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.