nextcloud / nextcloud/user_saml
Using comma as group separator is not conforming to standards/best-practices
Open
Nobody has claimed this yet.
1. to develop
enhancement
good first issue
- Dominant language
- PHP
- Stars
- 104
- Forks
- 85
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 16
Description
SAML-multivalue-attributes are commonly encoded separated by semicolons rather than commas: "group1;group2;group3".
Please change the separator in UserData:getGroups() to a semicolon. Or better yet, make it a configurable option.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the UserData:getGroups() entry point and trace how SAML multivalue group attributes are split. Check the surrounding tests or add coverage for the separator behavior; done means groups encoded with semicolons are parsed correctly, with any configurable separator behavior matching the issue's chosen scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100