nextcloud / nextcloud/user_saml
Allow multiple user backends when using SSO type "environment-variable"
Open
Nobody has claimed this yet.
1. to develop
enhancement
- Dominant language
- PHP
- Stars
- 104
- Forks
- 85
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 16
Description
Hi,
Our client would like to have the option to enable local (direct) login when using user_saml plugin in "environment-variable" type.
As this piece of code states, the option only exists when using "saml" type:
What we expect
- When using "environment-variable" type login, the settings page would give the possibility to select "Allow the use of multiple user back-ends (e.g. LDAP)" like it is already the case for "saml" type.
- With this option enabled in the settings, instead of instantly redirecting the user to SSO the login page would present 2 options:
- Direct login
- Login with SSO
Kind regards,
Thierry
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/SAMLSettings.php around lines 106-110 and compare how the multiple-user-backend option is handled for "saml" versus "environment-variable". Trace the environment-variable login flow to identify where its immediate redirect is selected. Done means the setting is available for that type and enabled users can choose Direct login or Login with SSO.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100