nextcloud / nextcloud/user_saml

Improve steps to download metadata XML

Open
#876 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement
Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

It is quite odd how one can setup SAML by generating a metadata XMl file for the IdP. When checking the following fields seemed required:

  • Service Provider Data: X509 certificate of the service provider
    • Hidden by default
    • We can hint to use openssl to generate one or even provide a button to generate one
  • Service Provider Data: private key of the service provider
    • Hidden by default
    • We can hint to use openssl to generate one or even provide a button to generate one
  • Identity provider Data: Identifier of the IdP entity (must be a URI)
  • Identity provider Data: URL Target of the IdP where the SP will send the Authentication Request Message
  • Identity provider Data: Public X.509 certificate of the IdP
    • Hidden by default

Additionally we should:

  • Properly indicate that this is a missing field when saving instead of just showing Invalid metadata and hiding an error message in the response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SAML metadata XML setup form and the save path that currently reports only invalid metadata. Review how the listed service-provider and identity-provider fields are displayed and validated. Done means required fields are clearly indicated, hidden certificate and key fields have generation guidance or controls, and missing-field errors are visible when saving.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.