nextcloud / nextcloud/user_saml

Can't login "normally" with SSO enabled

Open
#80 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

While I have SSO enabled and working configured via server variables, I can't login normally to my next cloud instance if I'm on a computer that isn't in my Kerberos Domain (or if I don't have a Kerberos session initiated).

Don't know if I'm missing something or not, but looking at the code at https://github.com/nextcloud/user_saml/blob/master/lib/Controller/SAMLController.php#L130-L135, instead of just showing a "Not provisioned" page, the "normal" login page should be shown (username/password login using whatever backend is cofigured)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/Controller/SAMLController.php around lines 130–135, where the current "Not provisioned" response is selected. Trace the login flow for users without a Kerberos session or domain connection and identify how the normal username/password login is reached. Done means those users see the configured normal login page instead of the provisioning page, while SSO remains available for eligible users.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.