nextcloud / nextcloud/user_saml

Invalid usernames allowed

Open
#750 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

Steps to reproduce
  1. Setup SAML with Auth0 (or another IdP with different username requirements to Nextcloud)
  2. Login to Nextcloud
  3. Use an app assuming a standard Nextcloud username e.g. Talk
Expected behaviour

The SSO & SAML app should convert usernames into a format compatible with Nextcloud or include a warning. Or perhaps a lookup table from the original username to a Nextcloud version?

Actual behaviour

The SSO & SAML app allows invalid usernames. This has a knock-on effect on other apps (see https://github.com/nextcloud/server/issues/40016) that assume a username looks like a valid Nextcloud username.

Server configuration

Operating system: Linux 5.4

Database: 10.5

PHP version: 8.1.19

Nextcloud version: 25.0.7 Enterprise

SSO & SAML app version: 5.2.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the SAML login with Auth0 described in the issue and inspect how the SSO & SAML app accepts and stores the IdP username. Review the linked Nextcloud server issue for the downstream failure. Done means the app has a defined, tested behavior for usernames that do not meet Nextcloud's requirements, including any warning or mapping behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.