nextcloud / nextcloud/user_saml
Re-add IDP ID upong logot
Open
Nobody has claimed this yet.
1. to develop
enhancement
- Dominant language
- PHP
- Stars
- 104
- Forks
- 85
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 16
Description
The logout method would clear the session which generates a new session id, so this should lead to a new cookie, so from my perspective clearing and setting afterwards should work fine.
Originally posted by @juliushaertl in https://github.com/nextcloud/user_saml/issues/683#issuecomment-1359981097
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the logout flow and inspect the referenced Nextcloud server code at lib/private/Session/Internal.php lines 109-111. Trace how the session is cleared and how the identity-provider ID is handled afterward; done means the IDP ID is present again after logout, with relevant authentication tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100