nextcloud / nextcloud/user_saml

Infinite redirect when user is disabled

Open
#549 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

Steps to reproduce
  1. Have a saml user that is disabled
  2. Try to authenticate as that user
Expected behaviour

Error message is displayed

Actual behaviour

https://github.com/nextcloud/user_saml/blob/a7aabdd71f7fd92bacb2ccd603ba1d9b4b7263a0/appinfo/app.php#L110-L120

  1. This code path will redirect to an error page.
  2. When the error page is being accessed, see step 1.
Server configuration

Master of all repos

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with appinfo/app.php around lines 110-120 and reproduce authentication with a disabled SAML user. Trace the redirect from the disabled-user error path to the error page, then verify that the error message is displayed without redirecting indefinitely.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.