nextcloud / nextcloud/user_saml

Attribute mapping settings hidden at wrong times

Open
#527 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

From somebodies screenshot in #397 I realized there was a whole panel of settings I couldn't see. The "Attribute mappings" were never showing up for me.

I futzed around with the code in the inspector and found the HTML was there, just hidden. It seems the settings are being show based on the "require_provisioned_account_ checkbox. The trouble is they aren't actually based on the checkbox, they seem to be based on TOGGLING the check box. The settings always load hidden when the page loads no matter what the state of the checkbox is. If you toggle it (whatever direction) the settings show up. This means that if you have the provisioning checkbox correct and come back to the settings page you can't see the relevant mapping settings at all.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the settings page and inspect the Attribute mappings panel alongside the require_provisioned_account_ checkbox. Reproduce the page-load and toggle behavior described in this issue and compare the panel visibility with the checkbox state. Done means the mappings are visible whenever the checkbox state requires them, including on initial page load.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.