nextcloud / nextcloud/user_saml
JavaScript JS: Usage of global variables - marked as deprecated
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 104
- Forks
- 85
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 16
Description
Hi all,
while going through the code of the plugin I found it is using global variables in the JavaScript part.
This style of programming is named 'deprecated' here:
https://docs.nextcloud.com/server/19/developer_manual/app/javascript-apis.html
Are there any plans to change to JS part of the plugin in the near future?
Thanks for informations regarding this and the work on the plugin itself!
Best Regards
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the plugin's JavaScript code and the linked Nextcloud Server 19 JavaScript APIs guidance. The issue names no files or tests, so first locate the global-variable usage and establish the supported replacement. Done should mean the deprecated global usage is removed and the relevant JavaScript behavior still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100