nextcloud / nextcloud/user_saml

UX issue in multiple IDP deletion

Open
#269 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
104
Forks
85
Avg merge
1d 15h
Merged PRs (30d)
16

Description

I found a small UX issue with the multiple IDP settings. If I create multiple IDPs it looks like this:

image

Now imagine that I want to delete the last two. After creating all of them "Provider 5" is selected, so clicking the trash bin will delete it:

image

After "Provider 5" was deleted, "Provider 1" will be selected but as the trash bin is at the end of the list (behind "Provider 4") it gives the impression that you can just continue clicking the trash bin to delete "Provider 4", while in fact it will delete "Provider 1"

I think we should improve this somehow, since there is no undo, warning, etc. Maybe the trash bin icon should be always next to the selected IDP and not at the end of the list? Or, in order to avoid that I always have to select the IDP first, don't show the trash bin by default but only on hover next the the corresponding IDP (therefore we would need to have enough spacing to show hide the icon in order to avoid that the line is moving around)?

@juliushaertl what do you think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Reproduce the multiple-IDP deletion flow shown in the screenshots, then inspect the settings UI entry point; done means the trash action clearly targets the IDP it appears beside or otherwise prevents deleting a different provider without warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.