nextcloud / nextcloud/user_retention
Invert logic of reminder_days appconfig to be relative to the actual expiration duration
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 11
- Forks
- 8
- Avg merge
- 11h 48m
- Merged PRs (30d)
- 1
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Changing the expiration can happen (e.g. from 9 to 6 months), but reminders being send 4 and 2 weeks before would be "targeted" 8 and 8.5 months as they are not adjusted. So having them set to 14 and 28 days instead and that being automatic relative to the 9 or 6 months is much better handle-able
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the appconfig entry for reminder_days and the code that calculates expiration and sends reminders. Confirm how the current 9- or 6-month expiration is represented, then define tests showing that 14- and 28-day reminders are measured relative to the configured expiration; done means those reminders adjust automatically when the expiration duration changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100