nextcloud / nextcloud/user_oidc

Figure out a proper way to trigger relevant LoginChain commands

Open
#561 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

technical debt
Dominant language
PHP
Stars
181
Forks
60
Avg merge
7h 34m
Merged PRs (30d)
26

Description

There might be quite a few things from https://github.com/nextcloud/server/blob/215aef3cbdc1963be1bb6bca5218ee0a4b7f1665/lib/private/Authentication/Login/Chain.php#L79-L91 that we don't run during our LoginController when a user logs in. Might be good to have a separate LoginChain to still perform those tasks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the LoginChain commands in lib/private/Authentication/Login/Chain.php at lines 79-91 with the flow in LoginController. Determine which login tasks are missing and how a separate LoginChain should be triggered. Done means the relevant commands run during OIDC login without duplicating or skipping existing login behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.