nextcloud / nextcloud/user_migration
`Notifier:prepare()` throws `InvalidArgumentException` in Nextcloud 34
Open
Nobody has claimed this yet.
0. Needs triage
bug
- Dominant language
- JavaScript
- Stars
- 30
- Forks
- 10
- Avg merge
- 6h 5m
- Merged PRs (30d)
- 12
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Install User Migration app
- Update Nextcloud to version 34
- Have a look at the logs
Expected behaviour
There should be no exceptions reported for the User Migration app.
Actual behaviour
The log shows this exception over and over again (every minute):
OCA\UserMigration\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.
Server configuration
Web server: Nginx 1.22.1
Database: MariaDB 10.11.18
PHP version: 8.4.23
Nextcloud version: 34.0.1
List of activated apps
``` Enabled: - activity: 7.0.0 - admin_audit: 1.24.0 - announcementcenter: 7.4.1 - appointments: 2.7.4 - appstore: 1.0.0 - bruteforcesettings: 7.0.0 - calendar: 6.5.1 - cloud_federation_api: 1.18.0 - contacts: 8.7.4 - dav: 1.39.0 - deck: 1.18.2 - drop_account: 3.0.0 - external: 9.0.1 - federatedfilesharing: 1.24.0 - files: 2.6.0 - files_downloadlimit: 5.2.0-dev.0 - files_lock: 34.0.0 - files_pdfviewer: 7.0.0-dev.0 - files_sharing: 1.26.0 - files_trashbin: 1.24.0 - files_versions: 1.27.0 - firstrunwizard: 7.0.0-dev.0 - groupfolders: 22.0.2 - logreader: 7.0.0 - lookup_server_connector: 1.22.0 - notes: 6.0.1 - notifications: 7.0.0-dev.1 - oauth2: 1.22.0 - office: 1.0.0 - password_policy: 6.0.0-dev.0 - photos: 7.0.0 - polls: 9.1.4 - privacy: 6.0.0-dev.1 - profile: 1.3.0 - provisioning_api: 1.24.0 - quota_warning: 1.24.0 - related_resources: 5.0.0-dev.0 - serverinfo: 6.0.0 - settings: 1.17.0 - sharebymail: 1.24.0 - suspicious_login: 12.0.0-dev.0 - text: 8.0.0 - theming: 2.9.0 - twofactor_backupcodes: 1.23.0 - twofactor_nextcloud_notification: 8.0.0 - twofactor_totp: 16.0.0 - updatenotification: 1.24.0 - user_migration: 10.4.0 - viewer: 7.0.0-dev.0 - webhook_listeners: 1.6.0 - workflowengine: 2.16.0 Disabled: - app_api: 34.0.0 (installed 5.0.2) - circles: 34.0.0 (installed 22.1.1) - comments: 1.24.0 (installed 1.0.0) - contactsinteraction: 1.15.0 (installed 1.1.0) - dashboard: 7.14.0 (installed 7.7.0) - encryption: 2.22.0 (installed 2.8.1) - federation: 1.24.0 (installed 1.3.0) - files_external: 1.26.0 (installed 1.19.0) - files_reminders: 1.7.0 (installed 1.1.0) - nextcloud_announcements: 6.0.0 (installed 1.9.0) - recommendations: 7.0.0 (installed 0.8.0) - support: 6.0.0 (installed 1.0.0) - survey_client: 6.0.0-dev.0 (installed 1.0.0) - systemtags: 1.24.0 (installed 1.0.2) - terms_of_service: 4.7.0 (installed 4.7.0) - testing: 1.23.0 - user_ldap: 1.25.0 - user_status: 1.14.0 (installed 1.1.1) - weather_status: 1.14.0 (installed 1.0.0) ```Nextcloud configuration
``` { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "serverid": 1, "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "sync.opencultureconsulting.com" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "version": "34.0.1.2", "dbtype": "mysql", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbname": "***REMOVED SENSITIVE VALUE***", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "installed": true, "default_language": "de", "force_language": false, "default_locale": "de_DE", "default_phone_region": "DE", "knowledgebaseenabled": true, "knowledgebase.embedded": false, "allow_user_to_change_display_name": true, "session_relaxed_expiry": true, "token_auth_enforced": true, "token_auth_activity_update": 90, "auth.bruteforce.protection.enabled": true, "auth.bruteforce.protection.force.database": false, "auth.bruteforce.protection.testing": false, "auth.bruteforce.max-attempts": 10, "ratelimit.protection.enabled": true, "auth.webauthn.enabled": true, "auth.storeCryptedPassword": true, "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": 587, "mail_smtptimeout": 10, "mail_smtpsecure": "", "mail_smtpauth": true, "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "mail_sendmailmode": "smtp", "overwrite.cli.url": "https:\/\/sync.opencultureconsulting.com", "trashbin_retention_obligation": "14,30", "versions_retention_obligation": "auto", "appcodechecker": true, "updatechecker": true, "updater.server.url": "***REMOVED SENSITIVE VALUE***", "updater.release.channel": "stable", "has_internet_connection": true, "check_for_working_wellknown_setup": true, "check_data_directory_permissions": true, "log_type": "file", "log_type_audit": "file", "logfile": "\/var\/log\/nextcloud\/nextcloud.log", "logfile_audit": "\/var\/log\/nextcloud\/audit.log", "loglevel": 2, "loglevel_frontend": 2, "log_rotate_size": 0, "profiler": false, "defaultapp": "dashboard,files", "appstoreenabled": true, "appstoreurl": "https:\/\/apps.nextcloud.com\/api\/v1", "enable_previews": true, "preview_concurrency_all": 8, "preview_concurrency_new": 4, "preview_max_x": 4096, "preview_max_y": 4096, "preview_max_filesize_image": 50, "preview_max_memory": 256, "metadata_max_filesize": 256, "max_file_conversion_filesize": 100, "maintenance": false, "maintenance_window_start": 4, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379, "timeout": 0 }, "mysql.utf8mb4": true, "theme": "", "theming.standalone_window.enabled": true, "encryption.use_legacy_base64_encoding": false, "filesystem_check_changes": 0, "memcache.locking": "\\OC\\Memcache\\Redis", "debug": false, "simpleSignUpLink.shown": false, "login_form_autocomplete": true, "profile.enabled": true, "bulkupload.enabled": true, "enable_non-accessible_features": true, "files.chunked_upload.max_size": 104857600, "files.chunked_upload.max_parallel_count": 5, "files.trash.delete": true, "encryption.legacy_format_support": false, "encryption.key_storage_migrated": false, "twofactor_enforced": "true", "twofactor_enforced_groups": [ "admin" ], "twofactor_enforced_excluded_groups": [], "app.mail.attachment-size-limit": 20971520, "app.mail.imap.timeout": 30, "app.mail.smtp.timeout": 10, "app.mail.sieve.timeout": 5, "app_install_overwrite": [], "config_preset": 6 } } ```Browser
Browser name: Chrome
Browser version: 150
Operating system: Ubuntu
Browser log
No issues there.Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at OCA\UserMigration\Notification\Notifier::prepare() and compare its behavior with the Nextcloud 34 notification contract described in the report. Reproduce the recurring log entry after upgrading, then verify that known and unknown notifications no longer produce the deprecated InvalidArgumentException warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100