nextcloud / nextcloud/updater

Error not show in web Updater when when there's an exception

Open
#84 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: check for update mode: web needs review UX🙂
Dominant language
PHP
Stars
51
Forks
40
Avg merge
2d 19h
Merged PRs (30d)
3

Description

When doing it via the admin page. There is one line being shown about doing the update and then nothing happens.
There needs to be an error message if the process is not going to even start.

From the command line, I get this:

Nextcloud Updater - version: 1.0.3

Current version is 11.0.0.


  [Exception]
  Could not do request to updater server: error setting certificate verify locations:
    CAfile: /usr/local/share/certs/ca-root-nss.crt
    CApath: none


update

The error message is too cryptic. What went really wrong?
If there is a problem with the certificates, why isn't this displayed in the admin panel when doing generic checks?

Exception from the logs

[04-Feb-2017 12:06:36 Europe/Zurich] PHP Fatal error:  Uncaught Exception: Could not do request to updater server: error setting certificate verify locations:
  CAfile: /usr/local/share/certs/ca-root-nss.crt
  CApath: none in /updater/index.php:514
Stack trace:
#0 /updater/index.php(224): Updater->getUpdateServerResponse()
#1 /updater/index.php(1443): Updater->checkForUpdate()
#2 {main}
  thrown in /updater/index.php on line 514

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in updater/index.php at the exception reported on line 514, then trace the calls through lines 224 and 1443 and the admin-page update flow. Reproduce the certificate error and inspect how generic checks report failures. Done means the web updater does not stop after its progress message and presents a useful error when the update cannot start.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.