nextcloud / nextcloud/updater

updater: rename "backup" step (WAS BEFORE: improve order: download, maint. mode, backup (backup should be last))

Open
#691 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug feature: backups
Dominant language
PHP
Stars
51
Forks
40
Avg merge
2d 19h
Merged PRs (30d)
3

Description

Issue changed, new: Rename "backup" operation to reflect it's only backupping "Nextcloud version's code".

The initial issue description was based upon a misunderstanding. See comment below:
https://github.com/nextcloud/updater/issues/691#issuecomment-3577463239

Just want to make sure there isn't a misunderstanding... This back up is only of the installed Nextcloud version's code. It does not include user data.

We may need to reword it in the UI / call it something else entirely (to minimize confusion).

That comment lists other issues on optimizing the order anyway.

 

 

ORIGINAL ISSUE DESCRIPTION

Problem: The download may take very long and changes done in the Nextcloud instance in the meanwhile are not backupped then.

Steps to reproduce
  1. update Nextcloud using web based updater or command line updater.phar
Expected behaviour
  1. First everything should be prepared. First probably the compatibility check, then the download.
  2. Nextcloud should be put in maintenance mode (lock)
  3. backup
  4. actual update
Actual behaviour
  1. backup
  2. download
  3. maintenance mode
  4. actual update

 

 

Server configuration

OS: Debian-13.2

Web server: Apache-2.4.65-2

Database: Maria-1:11.8.3-0+deb13u1

PHP version: 8.4.11-1

Nextcloud version: 31.0.10

List of activated apps 
Enabled:
  - activity: 4.0.0
  - app_api: 5.0.2
  - bruteforcesettings: 4.0.0
  - calendar: 5.5.9
  - circles: 31.0.0
  - cloud_federation_api: 1.14.0
  - comments: 1.21.0
  - contacts: 7.3.7
  - contactsinteraction: 1.12.1
  - dav: 1.33.0
  - federatedfilesharing: 1.21.0
  - federation: 1.21.0
  - files: 2.3.1
  - files_downloadlimit: 4.0.0
  - files_reminders: 1.4.0
  - files_sharing: 1.23.2
  - files_trashbin: 1.21.0
  - files_versions: 1.24.0
  - firstrunwizard: 4.0.0
  - logreader: 4.0.0
  - lookup_server_connector: 1.19.0
  - notes: 4.12.4
  - notifications: 4.0.0
  - oauth2: 1.19.1
  - password_policy: 3.0.0
  - photos: 4.0.0
  - privacy: 3.0.0
  - profile: 1.0.0
  - provisioning_api: 1.21.0
  - recommendations: 4.0.0
  - related_resources: 2.0.0
  - serverinfo: 3.0.0
  - settings: 1.14.0
  - survey_client: 3.0.0
  - systemtags: 1.21.1
  - text: 5.0.2
  - theming: 2.6.1
  - twofactor_backupcodes: 1.20.0
  - updatenotification: 1.21.0
  - user_status: 1.11.0
  - viewer: 4.0.0
  - webhook_listeners: 1.2.0
  - workflowengine: 2.13.0
Disabled:
  - admin_audit: 1.21.0
  - dashboard: 7.11.0 (installed 7.0.0)
  - encryption: 2.19.0
  - files_external: 1.23.0 (installed 1.12.0)
  - files_pdfviewer: 4.0.0 (installed 2.6.0)
  - nextcloud_announcements: 3.0.0 (installed 1.5.0)
  - registration: 2.8.0 (installed 2.8.0)
  - sharebymail: 1.21.0 (installed 1.15.0)
  - support: 3.0.0 (installed 1.8.0)
  - suspicious_login: 9.0.1
  - twofactor_nextcloud_notification: 5.0.0
  - twofactor_totp: 13.0.0-dev.0
  - user_ldap: 1.22.0
  - weather_status: 1.11.0 (installed 1.5.0)
Nextcloud configuration 
{
    "system": {
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "dbindex": 0,
            "timeout": 1.5
        },
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "example.net"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "31.0.11.2",
        "overwrite.cli.url": "https:\/\/example.net",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "default_language": "de",
        "maintenance": false,
        "theme": "",
        "loglevel": 0,
        "mail_smtpmode": "sendmail",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "app_install_overwrite": [
            "sharerenamer"
        ],
        "default_phone_region": "DE",
        "maintenance_window_start": 1
    }
}
Browser

Browser name: Firefox

Browser version: ESR-140.5.0

Operating system: Debian-13

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the updater's user-facing label for the backup operation and review the surrounding wording; done means the label clearly says the backup covers only the installed Nextcloud version's code, with relevant existing checks still passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
release
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.