nextcloud / nextcloud/updater

Refuse to run updater if `memory_limit` is below requirements

Open
#585 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: check for update robustness 💪
Dominant language
PHP
Stars
51
Forks
40
Avg merge
2d 19h
Merged PRs (30d)
3

Description

See #505, #316, etc.

Since it will fail anyhow, we should simply refuse to run the updater at all if the memory_limit is too low. This is particularly a problem in web-mode.

The message given to the operator should be something like "Too low, either fix the memory_limit to meet official system requirements or update manually. (Tip: the -d memory_limit=xxx option can be used at the command line as quick one-off solution)."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the updater's web-mode path and how it reads memory_limit, then compare that value with the official system requirements. The work is done when the updater refuses to proceed below the requirement and shows the operator the stated remediation message, including the command-line override tip.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.