nextcloud / nextcloud/updater

add `.php-ini` and `.php-version` to expected files

Open
#575 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feature: expected files hotspot: local changes
Dominant language
PHP
Stars
51
Forks
40
Avg merge
2d 19h
Merged PRs (30d)
3

Description

Even though the two files .php-ini and .php-version are not directly provided by nextcloud, they are however provided by my Plesk setup. It get's a bit annoying to have to move them out of the nextcloud folder in order to do the update, and then move them back in again after. I can't see any counter-indication to including them in the "expected" list?

https://github.com/nextcloud/updater/blob/3b634b922aa48f132e40e65006cae37a1705761e/index.php#L247-L297

May I create a PR that addresses this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open index.php around lines 247-297 and inspect how the expected file list is defined. Add .php-ini and .php-version to that list, then verify that the updater treats both Plesk-provided files as expected during an update.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.