The step file is getting left around after `finalize()`
Open
Nobody has claimed this yet.
1. to develop
bug
- Dominant language
- PHP
- Stars
- 51
- Forks
- 40
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 3
Description
This doesn't look right:
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] POST request for step "12"
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] startStep("12")
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] finalize()
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] storage location: /data/updater-ociz9efdik2y/downloads/nextcloud/
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] call opcache_reset()
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] end of finalize()
2024-05-25T05:44:01+0000 RnQG5qanp7 [info] endStep("12")
finalize() does the cleanup - removing the .step file - then we're also calling endStep("12") again somehow according to our logs. This re-adds a .step file again, stuck in step 12.
First seen while troubleshooting some updater issues on the forum, then reviewed the logs from running tests. Indeed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the finalize() and endStep("12") flow using the log sequence in the issue, focusing on why cleanup is followed by another step-file write. Review the existing tests that produce these updater logs. Done means finalize() does not leave a .step file recreated for the completed step.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100