nextcloud / nextcloud/updater

[Bug]: Updater backups don't support symlinks

Open
#484 2 comments 0 reactions 1 assignee View on GitHub

@joshtrichards is already working on this.

Since Apr 19, 2024.

2. developing bug feature: backups
Dominant language
PHP
Stars
51
Forks
40
Avg merge
2d 19h
Merged PRs (30d)
3

Description

⚠️ This issue respects the following points: ⚠️
Bug description

When running the updater, it backups symlinked files multiple times.

Steps to reproduce
  1. Install the "recognize" app
  2. Download the models and everything to make it ready to run
  3. Update Nextcloud
  4. The updater creates a backup, which contains three copies of the 400 MB file apps/recognize/node_modules/@tensorflow/tfjs-node-gpu/deps/lib/libtensorflow.so.2.9.1 in its symlinks apps/recognize/node_modules/@tensorflow/tfjs-node-gpu/deps/lib/libtensorflow.so.2 and apps/recognize/node_modules/@tensorflow/tfjs-node-gpu/deps/lib/libtensorflow.so
Expected behavior

apps/recognize/node_modules/@tensorflow/tfjs-node-gpu/deps/lib/libtensorflow.so.2.9.1 is only backed up once, and the symlinks are preserved as such.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.