nextcloud / nextcloud/unsplash
Tint strength and blur strength values not stored correctly
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 100
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!
- This is not a feature request
- This is not an image-provider request
- I have searched the issuetracker if the issue is not already reported.
Describe the bug:
When trying to change tint strength or blur strength in the Admin/Theming settings, the backrgound appearance doesn't change and, after a page reload, the sliders are back to their default values.
To Reproduce:
- Turn on tinting.
- Try to change tint strength and/or blur strength in Admin/Theming settings.
Expected behavior:
Background gets updated accordingly and sliders store correct values.
Server:
- Nextcloud version: 31.0.10
- Splash-App version: 3.1.0
Additional Information:
These two lines always set the returned value to the default value (30 and 0).
https://github.com/nextcloud/unsplash/blob/ff2ac675c256104c6b16c672bd6a1f688e9d020b/templates/settings/admin.php#L131
https://github.com/nextcloud/unsplash/blob/ff2ac675c256104c6b16c672bd6a1f688e9d020b/templates/settings/admin.php#L138
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in templates/settings/admin.php at the two lines linked in the issue, then reproduce the tint and blur changes from Admin/Theming settings and reload the page. Trace how those values are returned and used; done means the background updates and both sliders retain their selected values after reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100