nextcloud / nextcloud/twofactor_webauthn

UX on 2FA select challenge page is broken

Open
#335 3 comments 0 reactions 1 assignee View on GitHub

@st3iny is already working on this.

Since Nov 28, 2023.

2. developing bug design
Dominant language
JavaScript
Stars
59
Forks
11
Avg merge
1d 10h
Merged PRs (30d)
16

Description

Steps to reproduce
  1. Setup 2FA with both Authenticator App and a security key (for example SoloKey)
  2. Login
Expected behaviour

The page after the login form /login/selectchallenge should be usable with keyboard.

The "buttons" to select the 2FA method (either Authenticator App or Security Key) should be highlighted when using Tab key to switch focus between elements on the page.

The buttons (form) should have a visual appearance that is consistent with the rest of the default nextcloud style.

Actual behaviour

The "buttons" to select the 2FA method (either Authenticator App or Security Key) are not highlighted when using Tab key to switch focus between elements on the page.

It is impossible to know which button (method) is currently selected.

This was working in nextcloud 24.

The buttons look terrible, don't follow the default nextcloud style for buttons - see
swappy-20230122_120616

Server configuration

Operating system:

Web server:

Database:

PHP version:

Version: (see admin page)

Updated from an older version or fresh install: updated from 24

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

The content of config/config.php:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)
Client configuration

Browser: Firefox and Brave

Operating system: Manjaro Linux

Logs
Web server error log
Insert your webserver log here
Server log (data/nextcloud.log)
Insert your server log here
Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.