nextcloud / nextcloud/twofactor_gateway

Add an option to update keys

Open
#99 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement gateway:signal
Dominant language
PHP
Stars
122
Forks
63
Avg merge
3d 17h
Merged PRs (30d)
23

Description

When a user re-installs Signal or switches it's mobile, new keys will be generated. The implementation used by the signal web gateway does then refuse to send messages due to key mismatch (security-wise 👍).

I've added an endpoint to delete the existing key so communication is working again.

A button like "re-key" or "new phone" or something clever which hit's this endpoint using DELETE and the mobile number with country prefix but without the +.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository files or tests are named. Start by tracing the existing Signal or web-gateway configuration and how the mobile number is handled, then assess where the proposed DELETE request belongs. Done means a user can trigger re-keying after reinstalling or changing phones, using the country-prefixed number without '+', and messaging works again.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.