nextcloud / nextcloud/twofactor_gateway

Phone number verification - Need to specify country code.

Open
#327 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop help wanted
Dominant language
PHP
Stars
122
Forks
63
Avg merge
3d 17h
Merged PRs (30d)
23

Description

Certain SMS services (at least with sms77.io) will send SMS messages to the wrong person if the user doesn't specify their country code, which is a common thing to omit when entering their number. It'd be a good idea if the app specifically tells you to enter a country code, or a dropdown box with all the country codes of the world.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the phone-number input and the code that formats numbers before sending SMS messages through the gateway. Compare the current behavior with the reported sms77.io case, then determine whether requiring a country code or offering a country-code selector is the intended outcome; done means numbers without a code cannot be sent to the wrong recipient.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.