"Files" ressource in Smart Picker might mislead users

Currently if I want to attach a file to a Text file, i can use the "attach" action button that will open a file picker with a clear title:

If I only want to link to a file or folder from Files, i can use the Link action button that will open a File picker modal:

The problem:

• The Smart Picker offers a "Files" ressource which does not say anything about the picked item being attached or linked:
  
• If you do not pay attention to the title of the modal (like me), you might think that you actually upload a file
  

Solutions

1. Add a "Attach from Files" picker, rename the current Picker "Files -> Link from/to Files".
2. Another option, possible more complicated: Keep the generic name for "Files" picker but explicitly allow to choose in the modal:

Instead one action button:

[Choose {filename}]

Something like this

[Insert link to {filename}] [Insert {filename} as attachment]

I have no strong opinion but I believe that this should be somehow fixed. Either of the proposed solutions should not be too hard to implement, can def try to prepare a PR for this.

(I know this is not strictly a bug/issue in the text app but in the smart picker ressources themselves, but my understanding is that this is the repo where the correct design should be discussed?)

Start at the Smart Picker's "Files" resource and compare its picker/modal entry point with the attach and link action flows described. Done requires choosing and implementing a clarified interaction, but the issue names no files, tests, or definitive solution; the resulting labels and actions should clearly distinguish linking from attaching.