nextcloud / nextcloud/text

Only return and handle 409 responses during save requests

Open
#6,941 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
659
Forks
133
Avg merge
1d 20h
Merged PRs (30d)
110

Description

Describe the bug
We currently also return and handle 409 responses during sync requests.
This leads to two possible scenarios that can create such responses.
In addition the 409 will always include both - the sync data and the updated content of the file.
This is send again and again.

To Reproduce
Steps to reproduce the behavior:

  1. Open a file, create some versions, save the file
  2. keep editing and revert to a previous version
  3. See a conflict dialogue right away and inspect the network tab
  4. See ongoing 409 responses to sync requests.

Expected behavior
Only see 409 responses to save requests.

Screenshots and logs
Will be added later.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the version-revert scenario and inspect the network requests to trace where sync and save responses are handled. Find the existing 409 handling for these requests; done means sync requests no longer return or handle 409 responses, while save requests still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.