Folder description shows Text Editor/Viewer header on public share
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 659
- Forks
- 133
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 110
Description
Describe the bug
A folder with a folder description, when viewed from a public share link, shows the Text Editor/Viewer header (show/hide outline, last saved x min ago, Active people).
This can interfere with the first line of the description and brings no benefit.
It seems to be a broken form of the Text Editor/Viewer UI one also sees when opening a Text-File without write-permissions (on a public share or logged in).
To Reproduce
Steps to reproduce the behavior:
- Create a folder
- Share the folder using a public link (read-only)
- Add a folder description to the folder
- Open the public share link in another browser or an incognito window
- Observe the folder description and header above
Expected behavior
If the share link is read-only no Text Editor/Viewer header should be shown (like in the files app when the description is not being edited).
If the share link has sufficient permissions, the User should see the usual viewing/editing UI as seen in the Files App when logged in.
Screenshots
Viewing from the read-only public share link
Viewing from Files App
Editing from Files App
Server details:
- Nextcloud version: 30.0.5 (AIO)
- PHP Version: 8.3.16 (AIO)
- Database: PostgreSQL 16.6 (AIO)
Client details:
- OS: Fedora Workstation
- Browser: Firefox, Gnome Web, etc.
- Browser version: 135.0, 47.3.1, ...
- Device: laptop/desktop
Logs
Nextcloud log (data/nextcloud.log)
None
Browser log
22:55:10.587 Content-Security-Policy: The page’s settings blocked an event handler (script-src-attr) from being executed because it violates the following directive: “script-src 'nonce-aXA0jgbhtw97NAoR4V+aCfwlfLYxs7cXcJ7ee2Yirus='”
Source: event.preventDefault() 4 ExY5T3WJryk3XKt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with a folder description through a read-only public share, then compare it with the Files App in viewing and editing modes. Trace the public-share description entry point and determine why the Text Editor/Viewer header appears; done means read-only shares omit that header while permitted shares retain the expected viewing or editing UI.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100