Failing preview generation results in 404 istead of original image
Open
Nobody has claimed this yet.
1. to develop
bug
good first issue
php
- Dominant language
- JavaScript
- Stars
- 659
- Forks
- 133
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 110
Description
Describe the bug
We had some traces in Sentry:
Since we don't catch these they will be caught on the Controller Level which then sends a 404.
We should return the raw image instead. In case of the trace here it was a png and could have been served fine.
Server details:
cloud.nextcloud.com from 30.0.1.1 to 30.0.2.2 - probably longer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing a preview-generation failure for a PNG and trace the request through the preview and controller handling described in the issue. Done means a failed preview returns the original raw image instead of a 404 response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100