nextcloud / nextcloud/terms_of_service
Deprecated usage of notification notifier
Open
Nobody has claimed this yet.
1. to develop
technical debt
- Dominant language
- JavaScript
- Stars
- 40
- Forks
- 23
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 11
Description
{
"reqId": "zmocK7Zhtu3bDXD82WyI",
"level": 0,
"time": "2024-07-31T08:16:42+00:00",
"remoteAddr": "127.0.0.1",
"user": "admin",
"app": "no app in context",
"method": "GET",
"url": "/ocs/v2.php/apps/notifications/api/v2/notifications",
"message": "OCA\\TermsOfService\\Notifications\\Notifier::prepare() threw \\InvalidArgumentException which is deprecated. Throw \\OCP\\Notification\\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \\InvalidArgumentException yourself.",
"userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0",
"version": "30.0.0.3",
"data": []
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating OCA\TermsOfService\Notifications\Notifier::prepare() and inspect how it handles notification types. Confirm that unknown notifications use the specified exception and that valid notifications handle InvalidArgumentException without producing the reported deprecation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100