nextcloud / nextcloud/terms_of_service
Use hooks instead of stack trace inspection
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 40
- Forks
- 23
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 11
Description
Instead of inspecting the stack trace in https://github.com/nextcloud/terms_of_service/blob/36f2a483eb696d5f14d8bac8b3feb2f3b186a6ff/lib/Filesystem/Helper.php#L66, introduce (cancellable?) hooks in relevant classes in server.
The hooks could be called something like "beforeCopySkeleton" and "afterCopySkeleton"
- LoginController
- ClientFlowLoginController
- ClientFlowLoginV2Controller
- RegisterController
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/Filesystem/Helper.php line 66, then inspect LoginController, ClientFlowLoginController, ClientFlowLoginV2Controller, and RegisterController. Replace the stack-trace inspection with the agreed cancellable hooks, and consider the work done when all four controllers are covered by the hook flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100