nextcloud / nextcloud/terms_of_service
App-password should not be affected by ToS region
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 40
- Forks
- 23
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 11
Description
Any app-password will receive an Exception OCA\TermsOfService\TermsNotSignedException (for example when using WebDAV), until you accept the ToS. Once you have accepted the ToS, the app-password works. This is all good, until you have set up multiple ToS regions and try to access your instance with your app-password from another region. This can be an issue if you want to set up an automation in a virtual machine, residing in another region, where you might not have easy access to a browser to accept the ToS.
An option "allow app-passwords if ToS have been accepted in any region" would solve this issue without sacrificing functionality for users that see this behavior as a feature instead of a bug.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where OCA\TermsOfService\TermsNotSignedException is raised for app-password access, using the WebDAV path as a reproduction. Review how acceptance is checked across ToS regions, then define the option so app-passwords work when ToS has been accepted in any region. Done means the behavior is covered for both same-region and cross-region access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100