nextcloud / nextcloud/terms_of_service

Accept button is disabled even if all the text was read

Open
#1,094 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
40
Forks
23
Avg merge
3d 3h
Merged PRs (30d)
11

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce
  1. Create a new public share
  2. Open it with another browser
  3. The accept button often is disabled even if there is no scrollbar and all the text was shown/read
Expected behaviour

The accept button should be clickable

Actual behaviour

The accept button is disabled

Server configuration

Web server: Apache

Database: PostgreSQL

PHP version: 8.3

Nextcloud version: 31.0.4

Browser

Browser name: All of them

Operating system: Windows + Ubuntu + Mac

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the public-share flow in multiple browsers and inspect the frontend logic controlling the Accept button. Trace how the app decides that the terms have been read, then verify the button becomes clickable when the full text is shown and add or update a regression test if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.