nextcloud / nextcloud/terms_of_service
Performance: only add terms-of-service frontend script if the check is not passed yet
Open
Nobody has claimed this yet.
1. to develop
enhancement
- Dominant language
- JavaScript
- Stars
- 40
- Forks
- 23
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 11
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Feature request
Current process:
- App adds a frontend script
- Frontend makes an HTTP request to check for ToS being accepted
Proposal:
- Check for ToS on Backend
- Only add the frontend script if it is necessary
Result:
- Removes an unnecessary script from the page which is actually needed only once per user
- Removes HTTP request for a data that we could check in the first request
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by tracing the current frontend script and its HTTP request, then find where the backend can check terms-of-service acceptance in the first request. Done means the script and follow-up request are added only when acceptance is still required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- full-stack
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100