nextcloud / nextcloud/terms_of_service
vendor/ is dirty
Open
Nobody has claimed this yet.
1. to develop
bug
dependencies
php
technical debt
- Dominant language
- JavaScript
- Stars
- 40
- Forks
- 23
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 11
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
From https://github.com/nextcloud/terms_of_service/pull/1011 it becomes obvious:
- vendor/ bin is outdated/dirty
- mozart or php-scoper should be used to separate dependencies from dev-dependencies and not have the later one commited
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the vendor/ directory and vendor/bin, then read the referenced terms_of_service pull request #1011. Determine how mozart or php-scoper should separate dependencies from dev-dependencies; done means vendor/bin is no longer outdated or dirty and dev-dependencies are not committed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100