nextcloud / nextcloud/tasks

Recurrence: localization problem, missing context

Open Beginner friendly
#3,111 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
706
Forks
117
Avg merge
8h 50m
Merged PRs (30d)
18

Description

Steps to reproduce

You can select the monthly recurrence option when adding a new event, e.g. the third Friday can be selected. The options come from: this file.

Expected behavior

The mentioned string should use a different context, to allow distinguishing between the two usages.

Actual behaviour

Currently the string has no context, so it results in the same row in PO file. In English there is no issue, as the sixtieth of a minute and ordinal two are both second, but in languages where these use different words, it's an issue that can't be solved with workarounds.

Tasks app version

0.17.1

Additional info
Image

Screenshot for reference: in Hungarian it should say második instead of másodperc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the recurrence option definitions in src/filters/recurrenceRuleFormat.js, especially the string referenced around line 19. Check how the two usages are extracted into PO files and separate their translation contexts. Done means translators can distinguish the ordinal wording from the time-unit wording, including the Hungarian case described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.