nextcloud / nextcloud/talk-ios

Optimize reloadData in RoomsTableViewController

Open
#1,293 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
230
Forks
121
Avg merge
1d 6h
Merged PRs (30d)
38

Description

I just noticed that we now have the case that we call `self.tableView reloadData` twice when `refreshRoomList` is called and we don't have a search string. Once it's done inside of `filterRooms` and once in `refreshRoomList`. Not sure if this will be a problem in the real world or if iOS might even optimize the two calls, but we should keep that in mind and optimize that in the long run.

_Originally posted by @SystemKeeper in https://github.com/nextcloud/talk-ios/pull/1289#pullrequestreview-1513322065_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.