nextcloud / nextcloud/talk-desktop
Notifications overview
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 525
- Forks
- 85
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 35
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Notifications reliability
- https://github.com/nextcloud/talk-desktop/issues/378
- https://github.com/nextcloud/talk-desktop/issues/699
Notifications are sometimes not reliable. Especially when an app is not used, notifications can be delayed and then many notifications shown simultaneously.
- Improve notifications logging
- Hypothesis 1 - Chromium suspends WS connection (most likely)
- In this case we should move notifications handling to the main process in Talk Desktop
- Make
notify_pushfrontend environment independent
- Make
- Alternative - Web Push API
- In this case we should move notifications handling to the main process in Talk Desktop
- Hypothesis 2 - There is a problem with
notify_pushfrontend - Hypothesis 3 - There is a problem with
notify_pushbackend
Notifications implementations
Currently Talk Desktop stores a copy of notifications app source code. This results in handling issues in 2 places.
- In the
notificationsapp separate:- Notifications core (UI, web-browser, and Vue independent)
- Talk related notifications handling
- Frontend
- In the
notificationsapp provide all above as a library and publish tonpm - Reuse in Talk Desktop
Notifications visibility
- https://github.com/nextcloud/talk-desktop/issues/391
- https://github.com/nextcloud/talk-desktop/issues/85
Currently notifications are only visible in the notifications center on the system level.
- Add Talk frontend API to get the number of unread messages as well as subscribe to an update
- Use this API to show the number in the badge
- Add UI to see the list of notifications
Other improvements
- Update existing notification when possible:
- Update notification text on the message edit
- Remove notification when the message has been deleted
- Replace "Incoming call" notification with "Missed call"
- Make sure information from notifications, conversations list, and conversation are inline
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review linked issues 378, 699, 1151, 391, and 85, then inspect the notifications app copy used by Talk Desktop. Trace notify_push and the frontend notification handling, including the proposed main-process path; done would require an agreed subset of the reliability, reuse, visibility, and notification-update improvements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript
- Domain
- backend, desktop, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100