nextcloud / nextcloud/talk-desktop
Meta issue: Security improvement
Open
@ShGKme is already working on this.
Since Feb 6, 2023.
bug
- Dominant language
- JavaScript
- Stars
- 525
- Forks
- 85
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 35
Description
Checklist:
- Remove
SameSite=Lax -> SameSite=Nonecookies patching (fixed in: https://github.com/nextcloud/talk-desktop/pull/22) -
#18 - Follow Electron / Best Practices / Security
- 1. Only load secure content
- 2. Do not enable Node.js integration for remote content
- 3. Enable Context Isolation
- 4. Enable process sandboxing
- 5. Handle session permission requests from remote content
- 6. Do not disable
webSecurity(https://github.com/nextcloud/talk-desktop/pull/22) - 7. Define a Content Security Policy
- 8. Do not enable
allowRunningInsecureContent - 9. Do not enable experimental features
- 10. Do not use
enableBlinkFeatures - 11. Do not use
allowpopupsforWebViews - 12. Verify
WebViewoptions before creation - 13. Disable or limit navigation
- 14. Disable or limit creation of new windows
- 15. Do not use
shell.openExternalwith untrusted content - 16. Use a current version of Electron
- 17. Validate the sender of all IPC messages
- 18. Avoid usage of the
file://protocol and prefer usage of custom protocols (https://github.com/nextcloud/talk-desktop/pull/1204) - 19. Check which
fusesyou can change - 20. Do not expose Electron APIs to untrusted web content
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.