nextcloud / nextcloud/talk-desktop
[Bug] Browser, which was opened with external link from Desktop client `dev build`, is closed along with the app
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 525
- Forks
- 85
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 35
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Launch an application
- Open an external link (for example, from About window - OS browsers should be closed at this moment)
- Close an application (completely, with Quit)
- See result
Expected behaviour
⚠️ OS browser shouldn't be closed from outside
Actual behaviour
⚠️ App considered OS browser as a its part and close it
Desktop client
Talk Desktop client version: v0.9.0
Operating system: Ubuntu
Operating system version: Ubuntu 22.04.3 LTS
Server
Nextcloud version: dev
Talk app version: 18 (dev)
Custom Signaling server configured: yes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue on Ubuntu 22.04.3 with Talk Desktop v0.9.0 using the listed steps, then trace the desktop app's external-link handling and shutdown behavior. Done means an OS browser opened from an external link remains open after the application is completely quit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100