nextcloud / nextcloud/talk-desktop
Talk client doesn't respect system wide dnd (do not disturbe) setting
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 525
- Forks
- 85
- Avg merge
- 8h 5m
- Merged PRs (30d)
- 35
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
I use heavily the DND setting of Gnome when I'm in meeting to avoid getting disturbed by a lot of notifications from different apps.
This works great for many apps, but the Talk desktop client doesn't recognize the status.
Describe the solution you'd like
I did some initial research. This seems to be needed to respect the desktop wide dnd status:
- monitor the status:
gsettings monitor org.gnome.desktop.notifications show-banners - if it is "false" don't send notifications to the desktop
Describe alternatives you've considered
Always set it manually directly in the talk app, but this doesn't really scale.
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Talk desktop notification entry point and use gsettings monitor org.gnome.desktop.notifications show-banners to observe the GNOME setting described in the issue. The feature is complete when notifications are suppressed while the setting is false and resume when it is true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript
- Domain
- desktop, operating-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100